fix: ensure types are built before launching extension #4012
Conversation
This fixes the issue where F5 fails after a fresh clone because the types package is not built yet. The fix adds a build:roo-code-types task that runs before any watchers start. Adds the build task as a dependency to the watch task, ensuring the types are properly built at least once before the extension launches. Fixes: #4011 Signed-off-by: Eric Wheeler <[email protected]>
|
@mrubens @daniel-lxs @cte this fixes a build problem that will affect our new developers (was probably introduced by monorepo) |
cte
left a comment
cte
left a comment
There was a problem hiding this comment.
As I add more packages to the monorepo it will become more important to manage task dependencies in a clean way. We're using turborepo which will automatically build the monorepo package dependencies if we configure these watch commands as tasks:
https://turborepo.com/docs/crafting-your-repository/configuring-tasks
I will have some time to fix this broken case you found using turborepo tomorrow unless you want to take a crack at it.
I not familiar with the new build environment so please do, as you are certainly the expert here. This does not affect us too much because we can simply run |
Co-authored-by: Elephant Lumps <[email protected]>
3 participants
Context
When doing a fresh clone and running the extension with F5, it currently fails because the types package is not built before the watchers start. This causes errors when trying to import from packages that depend on the built types.
Implementation
This PR adds a new task called
build:roo-code-typesthat builds the types package once. Thewatchtask is then updated to depend on this build task, ensuring the types are properly built before any watchers start.The solution is minimal and ensures proper initialization sequence when launching the extension.
How to Test
cd Roo-ClineFixes #4011